Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements a major v2 API migration for the ClawSwap SDK, introducing breaking changes to field names, response structures, and error handling patterns. The core SDK implementation (packages/sdk/src/) has been successfully updated to v2 with comprehensive test coverage. However, the browser example applications (examples/browser/ and examples/browser-wagmi/) have not been updated and still use v1 API field names, making them non-functional. A new browser-wagmi example was added to demonstrate integration with wagmi v2 and ConnectKit.
Changes:
- Core SDK updated to v2 API with new field names (sourceChain/sourceToken vs sourceChainId/sourceTokenAddress, userWallet/recipient vs senderAddress/recipientAddress)
- Response structures changed (estimatedOutput vs destinationAmount, requestId vs orderId, new fee structure)
- Error handling updated with new error types and suggestion fields
- New browser-wagmi example added demonstrating wagmi v2 integration
- Test files updated and passing with v2 API
Reviewed changes
Copilot reviewed 43 out of 46 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/src/types.ts | Updated to v2 API types with renamed fields and new response structures |
| packages/sdk/src/schemas.ts | Updated validation schemas for v2 field names |
| packages/sdk/src/errors.ts | New error types and v2 error envelope structure |
| packages/sdk/src/client.ts | Client methods updated for v2 API, improved token fetching optimization |
| packages/sdk/src/utils/polling.ts | Updated terminal status check for v2 statuses |
| packages/sdk/src/utils/http.ts | Updated error handling for v2 error envelope |
| packages/sdk/tests/*.test.ts | Comprehensive test updates for v2 API |
| examples/node-cli/ | Successfully updated to v2 API |
| examples/browser/ | NOT updated - still uses v1 API (critical issue) |
| examples/browser-wagmi/ | NOT updated - still uses v1 API (critical issue) |
| pnpm-workspace.yaml | Added browser-wagmi example to workspace |
| README.md | Updated documentation for v2 API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.